Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #950

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Refactor #950

merged 4 commits into from
Oct 30, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Oct 22, 2024 •
edited
Loading

Changelog

- description: |
    Shuffle around modules
    Delete Cardano.CLI.Pretty and Cardano.CLI.IO.Compat
  type:
  - refactoring    # QoL changes

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/20241022-cleanup branch from 4f0fca7 to 5e2dcb1 Compare October 22, 2024 15:19
@Jimbo4350 Jimbo4350 marked this pull request as ready for review October 22, 2024 15:20
@Jimbo4350 Jimbo4350 force-pushed the jordan/20241022-cleanup branch from 5e2dcb1 to b0ccaf2 Compare October 22, 2024 15:20
palas
palas approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@palas palas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems innocuous function moving except for: posixSetOtherAndGroupModes, putLn, hPutLn, sem, and consoleBracket, which seem to be removed by the PR, but they seem to not be used anywhere in cardano-cli

@Jimbo4350 Jimbo4350 force-pushed the jordan/20241022-cleanup branch from b0ccaf2 to 76196a9 Compare October 28, 2024 16:48
@Jimbo4350 Jimbo4350 force-pushed the jordan/20241022-cleanup branch from 76196a9 to a0766b4 Compare October 30, 2024 12:26
@Jimbo4350 Jimbo4350 enabled auto-merge October 30, 2024 12:29
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 447fa87 Oct 30, 2024
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/20241022-cleanup branch October 30, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palas palas palas approved these changes

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@smelc smelc Awaiting requested review from smelc

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jimbo4350 @carbolymer @palas